Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

impl Arbitrary for IpAddr #157

Merged
merged 1 commit into from Jun 29, 2023
Merged

impl Arbitrary for IpAddr #157

merged 1 commit into from Jun 29, 2023

Conversation

jyn514
Copy link
Contributor

@jyn514 jyn514 commented Jun 29, 2023

This complements the existing impls for Ipv4Addr and Ipv6Addr.

fitzgen
fitzgen reviewed Jun 29, 2023
View reviewed changes
Copy link
Member

@fitzgen fitzgen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Just a couple nitpicks to be addressed and we can merge this.

src/lib.rs Outdated Show resolved Hide resolved
src/lib.rs Outdated Show resolved Hide resolved
@jyn514
impl Arbitrary for IpAddr
7d3364e 
This complements the existing impls for Ipv4Addr and Ipv6Addr.
@jyn514
Copy link
Contributor Author

jyn514 commented Jun 29, 2023

thanks for the quick review! committed both suggestions :)

@Manishearth Manishearth merged commit 80d6bfe into rust-fuzz:main Jun 29, 2023
5 checks passed
@jyn514 jyn514 deleted the ip-addr branch June 29, 2023 19:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fitzgen fitzgen fitzgen left review comments

@Manishearth Manishearth Manishearth approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jyn514 @fitzgen @Manishearth