Remove redundant range check #32
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
stevenroose
approved these changes
Apr 30, 2019
|
Can we close this after the work done on #35? Or does this need a simple rebase? |
|
I thought about that too. It isn't redundant and would just need a rebase, but while it's obvious to us now that the invariants hold it might not be in the future, so maybe leaving it as is is actually best. I'll close it for now, if you disagree feel free to reopen, I should have put more thought into it before opening the PR (just noticed it when reviewing something else). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since
u5is defined in this crate it can be instantiated directly avoiding a redundant range check.