Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improving the documentation concerning Connection::open #332

Closed
kkayal opened this issue Feb 16, 2018 · 2 comments
Closed

Improving the documentation concerning Connection::open #332

kkayal opened this issue Feb 16, 2018 · 2 comments

Comments

@kkayal
Copy link

kkayal commented Feb 16, 2018

The documentation says:

Connection::open(path) is equivalent to Connection::open_with_flags(path, SQLITE_OPEN_READ_WRITE | SQLITE_OPEN_CREATE)

The source is located in lib.rs line 197.

This doesn't compile as is. So, I have opened a stackoverflow question and received a good answer.

So I suggest to replace this statement with the following:

Connection::open(path) is equivalent to Connection::open_with_flags(path, OpenFlags::SQLITE_OPEN_READ_WRITE | OpenFlags::SQLITE_OPEN_CREATE)

@gwenn
Copy link
Collaborator

gwenn commented Feb 21, 2018

Indeed.
The regression was introduced by 28d5852
See https://github.com/rust-lang-nursery/bitflags/releases/tag/1.0.0

gwenn added a commit to gwenn/rusqlite that referenced this issue Mar 24, 2018
gwenn added a commit that referenced this issue Mar 24, 2018
Fix Connection::open documentation (#332)
@gwenn
Copy link
Collaborator

gwenn commented Aug 17, 2018

rusqlite 0.14 released

@gwenn gwenn closed this as completed Aug 17, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants