Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed issue #17671 by adding the required decorators #17678

Merged
merged 2 commits into from
Jan 31, 2025

Conversation

Riddhimaan-Senapati
Copy link
Contributor

@Riddhimaan-Senapati Riddhimaan-Senapati commented Jan 30, 2025

Description

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Fixes #17671

The .achat and .acomplete method in the Gemini client (/llama-index-integrations/llms/llama-index-llms-gemini/llama_index/llms/gemini/base.py) do not have the @llm_completion_callback() and @llm_chat_callback() decorators. So I added them. This should solve issue #17671

New Package?

Did I fill in the tool.llamahub section in the pyproject.toml and provide a detailed README.md for my new integration or package?

  • Yes
  • No

Version Bump?

Did I bump the version in the pyproject.toml file of the package I am updating? (Except for the llama-index-core package)

  • Yes
  • No

Type of Change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Your pull-request will likely not be merged unless it is covered by some form of impactful unit testing.

  • I added new unit tests to cover this change
  • I believe this change is already covered by existing unit tests

Suggested Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added Google Colab support for the newly added notebooks.
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I ran make format; make lint to appease the lint gods

Sorry, something went wrong.

Verified

This commit was signed with the committer’s verified signature.
haoqunjiang Haoqun Jiang
@dosubot dosubot bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label Jan 30, 2025
@Riddhimaan-Senapati
Copy link
Contributor Author

@logan-markewich @tobi @wpiekutowski @xevo @bborn Can anyone of you review my PR?

…the gemini integration
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Jan 31, 2025
@logan-markewich logan-markewich merged commit 0a6fa89 into run-llama:main Jan 31, 2025
10 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm This PR has been approved by a maintainer size:XS This PR changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Gemini Client does not have callbacks for async methods (achat, acomplete)
3 participants