Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Support Milvus collection properties #15241

Merged
merged 2 commits into from
Aug 9, 2024
Merged

Conversation

jaelgu
Copy link
Contributor

@jaelgu jaelgu commented Aug 9, 2024

Description

Add a new init parameter for MilvusVectorStore: collection_properties. This will support to set properties for Milvus collection: https://milvus.io/api-reference/pymilvus/v2.4.x/ORM/Collection/set_properties.md

Fixes # (issue)

Type of Change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Added new unit/integration tests
  • Added new notebook (that tests end-to-end)
  • I stared at the code and made sure it makes sense

Sorry, something went wrong.

Signed-off-by: Jael Gu <mengjia.gu@zilliz.com>
@dosubot dosubot bot added the size:S This PR changes 10-29 lines, ignoring generated files. label Aug 9, 2024
@jaelgu jaelgu changed the title Support Milvus collection properties feat: Support Milvus collection properties Aug 9, 2024
Copy link
Contributor

@nerdai nerdai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @jaelgu!

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Aug 9, 2024
@nerdai nerdai merged commit c4abfb7 into run-llama:main Aug 9, 2024
8 checks passed
@jaelgu jaelgu deleted the milvus-mmap branch August 12, 2024 01:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm This PR has been approved by a maintainer size:S This PR changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants