Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: strip '''sql (Markdown SQL code snippet) in SQL Retriever #15235

Merged
merged 1 commit into from
Aug 9, 2024

Conversation

panilya
Copy link
Contributor

@panilya panilya commented Aug 8, 2024

Description

Improve generated SQL query stripping by stripping ``` with the "SQL" text. There are cases when the AI model generates a SQL query wrapped with a Markdown SQL code snippet which is currently not being handled correctly resulting in the generated incorrect SQL query that fails to retrieve data from the database.

Fixes # (issue)

New Package?

Did I fill in the tool.llamahub section in the pyproject.toml and provide a detailed README.md for my new integration or package?

  • Yes
  • No

Version Bump?

Did I bump the version in the pyproject.toml file of the package I am updating? (Except for the llama-index-core package)

  • Yes
  • No

Type of Change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Added new unit/integration tests
  • Added new notebook (that tests end-to-end)
  • I stared at the code and made sure it makes sense

Suggested Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added Google Colab support for the newly added notebooks.
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I ran make format; make lint to appease the lint gods

Sorry, something went wrong.

Verified

This commit was signed with the committer’s verified signature. The key has expired.
levrik Levin Rickert
@dosubot dosubot bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label Aug 8, 2024
Copy link
Contributor

@nerdai nerdai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @panilya!

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Aug 9, 2024
@nerdai nerdai enabled auto-merge (squash) August 9, 2024 21:01
@nerdai nerdai merged commit 9dbf1f2 into run-llama:main Aug 9, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm This PR has been approved by a maintainer size:XS This PR changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants