Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Neo4jPropertyGraphStore.get() check for id prop #15228

Merged
merged 3 commits into from
Aug 9, 2024
Merged

Conversation

akollegger
Copy link
Contributor

@akollegger akollegger commented Aug 8, 2024

Description

Neo4jPropertyGraphStore.get() makes assumptions about the current graph which may be wrong, particularly if an existing graph is being used which has nodes that lack an id property. The get() may construct the wrong WHERE clause if both ids and properties are passed in as arguments.

This fix:

  • always check for existence of id property with a WHERE e.id IS NOT NULL clause
  • allows for both ids and properties to be passed in together

Fixes # (issue)

I search, but have not found an existing issue. Shall I open one?

New Package?

Did I fill in the tool.llamahub section in the pyproject.toml and provide a detailed README.md for my new integration or package?

  • Yes
  • No

Version Bump?

Did I bump the version in the pyproject.toml file of the package I am updating? (Except for the llama-index-core package)

  • Yes
  • No

Type of Change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Added new unit/integration tests
  • Added new notebook (that tests end-to-end)
  • I stared at the code and made sure it makes sense

Suggested Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added Google Colab support for the newly added notebooks.
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I ran make format; make lint to appease the lint gods

Sorry, something went wrong.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
…d property; allow for both ids and properties to be passed in together (rather than assuming either/or)
@dosubot dosubot bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label Aug 8, 2024
Copy link
Collaborator

@logan-markewich logan-markewich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

makes sense. We can also bump the version on the package integraiton in the pyproject.toml so that it publishes

Copy link
Contributor

@nerdai nerdai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @akollegger!

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Aug 9, 2024
@nerdai nerdai enabled auto-merge (squash) August 9, 2024 21:06
@nerdai nerdai merged commit 84bb6b7 into run-llama:main Aug 9, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm This PR has been approved by a maintainer size:XS This PR changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants