-
Notifications
You must be signed in to change notification settings - Fork 4.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for Vertex AI Vector Search as Vector Store #13186
Conversation
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
...ex-vector-stores-vertexaivectorsearch/llama_index/vector_stores/vertexaivectorsearch/base.py
Outdated
Show resolved
Hide resolved
ref_doc_id (str): The doc_id of the document to delete. | ||
|
||
""" | ||
self._index.remove_datapoints(datapoint_ids=[ref_doc_id]) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is actually meant to be a filtered delete -- deleting any point with ref_doc_id==ref_doc_id
in the metadata
Is this possible to do here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes. Needs two operations. Updated with filtered delete based on ref_doc_id
Description
This features adds support for Vertex AI Vector Search as vector store integration in LlamaIndex.
New Package?
Did I fill in the
tool.llamahub
section in thepyproject.toml
and provide a detailed README.md for my new integration or package?Version Bump?
Did I bump the version in the
pyproject.toml
file of the package I am updating? (Except for thellama-index-core
package)Type of Change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Suggested Checklist:
make format; make lint
to appease the lint gods