Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Vertex AI Vector Search as Vector Store #13186

Merged
merged 13 commits into from
May 3, 2024

Conversation

RajeshThallam
Copy link
Contributor

Description

This features adds support for Vertex AI Vector Search as vector store integration in LlamaIndex.

New Package?

Did I fill in the tool.llamahub section in the pyproject.toml and provide a detailed README.md for my new integration or package?

  • Yes
  • No

Version Bump?

Did I bump the version in the pyproject.toml file of the package I am updating? (Except for the llama-index-core package)

  • Yes
  • No

Type of Change

Please delete options that are not relevant.

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Added new unit/integration tests
  • Added new notebook (that tests end-to-end)
  • I stared at the code and made sure it makes sense

Suggested Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added Google Colab support for the newly added notebooks.
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I ran make format; make lint to appease the lint gods

Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@RajeshThallam RajeshThallam marked this pull request as ready for review May 2, 2024 16:34
@dosubot dosubot bot added the size:XXL This PR changes 1000+ lines, ignoring generated files. label May 2, 2024
ref_doc_id (str): The doc_id of the document to delete.

"""
self._index.remove_datapoints(datapoint_ids=[ref_doc_id])
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is actually meant to be a filtered delete -- deleting any point with ref_doc_id==ref_doc_id in the metadata

Is this possible to do here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. Needs two operations. Updated with filtered delete based on ref_doc_id

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label May 3, 2024
@logan-markewich logan-markewich merged commit 0b5ddc5 into run-llama:main May 3, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm This PR has been approved by a maintainer size:XXL This PR changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants