Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should redirect API docs for mongo to a notebook #11053

Merged
merged 2 commits into from
Feb 20, 2024
Merged

Conversation

seldo
Copy link
Contributor

@seldo seldo commented Feb 20, 2024

Description

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Fixes # (issue)

Type of Change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Added new unit/integration tests
  • Added new notebook (that tests end-to-end)
  • I stared at the code and made sure it makes sense

Suggested Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added Google Colab support for the newly added notebooks.
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I ran make format; make lint to appease the lint gods

Sorry, something went wrong.

@dosubot dosubot bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label Feb 20, 2024
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Feb 20, 2024
@seldo seldo merged commit df74e5c into main Feb 20, 2024
8 checks passed
@seldo seldo deleted the ljv/mongo-redirect branch February 20, 2024 23:45
Dominastorm pushed a commit to uptrain-ai/llama_index that referenced this pull request Feb 28, 2024

Verified

This commit was signed with the committer’s verified signature.
Dominastorm Dhruv Chawla
Co-authored-by: Logan Markewich <logan.markewich@live.com>
anoopshrma pushed a commit to anoopshrma/llama_index that referenced this pull request Mar 2, 2024
Co-authored-by: Logan Markewich <logan.markewich@live.com>
Izukimat pushed a commit to Izukimat/llama_index that referenced this pull request Mar 29, 2024
Co-authored-by: Logan Markewich <logan.markewich@live.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm This PR has been approved by a maintainer size:XS This PR changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants