fix: Correct Google GenAI extension import #11048
Merged
+2
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
the
size:XS
| @@ -137,7 +137,7 @@ def get_response( | |||
| A `SynthesizedResponse` object. | |||
| """ | |||
| try: | |||
| import llama_index.vector_stores.google as genaix | |||
| import llama_index.vector_stores.google.genai_extension as genaix | |||
There was a problem hiding this comment.
both of these imports worked for me, but sure, more specific is fine
logan-markewich
approved these changes
Feb 20, 2024
Dominastorm
pushed a commit
to uptrain-ai/llama_index
that referenced
this pull request
Feb 28, 2024
anoopshrma
pushed a commit
to anoopshrma/llama_index
that referenced
this pull request
Mar 2, 2024
Izukimat
pushed a commit
to Izukimat/llama_index
that referenced
this pull request
Mar 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes wrong import in Google Response Synthesizers. Issue was identified by using this notebook:
https://github.com/run-llama/llama_index/blob/main/docs/examples/managed/GoogleDemo.ipynb
Fixes # (issue)
Type of Change
Please delete options that are not relevant.
How Has This Been Tested?
Running GoogleDemo.ipynb gives error 'AttributeError: module 'llama_index.vector_stores.google' has no attribute 'build_generative_service''. I identified that the correct import is import llama_index.vector_stores.google.genai_extension which fixes the issue.
Suggested Checklist: