Update rag.py for ServiceContext and Response #11043
Merged
+6
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I had a problem using the CLI, similar to run-llama#10634 I wonder if it's because of the old import statements in this file. Please check and see if it's an appropriate patch before moving to Settings
dosubot
bot
added
the
size:XS
| @@ -7,15 +7,14 @@ | |||
| from typing import Any, Callable, Dict, Optional, Union, cast | |||
|
|
|||
| from llama_index.core import ( | |||
| Response, | |||
| ServiceContext, | |||
There was a problem hiding this comment.
Both of these imports work fine for me, but sure, more specific imports is fine too
There was a problem hiding this comment.
I would suggest making a fresh venv if those imports were causing issues tbh
logan-markewich
approved these changes
Feb 20, 2024
Dominastorm
pushed a commit
to uptrain-ai/llama_index
that referenced
this pull request
Feb 28, 2024
anoopshrma
pushed a commit
to anoopshrma/llama_index
that referenced
this pull request
Mar 2, 2024
Izukimat
pushed a commit
to Izukimat/llama_index
that referenced
this pull request
Mar 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I had a problem using the upgrade CLI, similar to #10634
I wonder if it's because of the old import statements in this file. Please check and see if it's an appropriate patch before moving to Settings
Description
Similar issues with old ServiceContext and other old import statements. But I am not sure if the Response referred to is the same one as the new one I referred to. However, I couldn't find any other similarly-named "Response" in the docs, so I assumed this was correct.
However, according to this, the ServiceContext should be depreciated fully instead of a quick fix like this - https://docs.llamaindex.ai/en/stable/module_guides/supporting_modules/service_context_migration.html
I might have missed other old imports but I'm not familiar enough to check through it all. I guess we will see if this version errors out and fix it again 😆
Type of Change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Suggested Checklist:
make format; make lintto appease the lint gods