fix linting with mypy + precommit? #10945
Merged
+149
−100,548
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
the
size:S
nerdai
approved these changes
Feb 18, 2024
| @@ -113,11 +113,11 @@ def tokenizer(self) -> Callable[[str], List[Any]]: | |||
| """Get the tokenizer.""" | |||
| import llama_index.core | |||
|
|
|||
| if llama_index.global_tokenizer is None: | |||
| if llama_index.core.global_tokenizer is None: | |||
There was a problem hiding this comment.
I could've sworn we've fixed this before. I remember doing search for global_tokenizer specifically. Maybe got overwritten?
There was a problem hiding this comment.
it might have gotten overwritten at some point lol
There was a problem hiding this comment.
lots of moving parts lately
There was a problem hiding this comment.
Lol yah that's for sure. Oh well -- we do our best!
dosubot
bot
added
size:L
Dominastorm
pushed a commit
to uptrain-ai/llama_index
that referenced
this pull request
Feb 28, 2024
anoopshrma
pushed a commit
to anoopshrma/llama_index
that referenced
this pull request
Mar 2, 2024
Izukimat
pushed a commit
to Izukimat/llama_index
that referenced
this pull request
Mar 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current pre-commit config was missing errors in mypy (I purposely tried to make typing errors, and they weren't detected)
From my local testing, this seems to have fixed the issue (and also identified some issues in core!)