Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removes command_line from core #10772

Merged
merged 25 commits into from
Feb 21, 2024
Merged

Removes command_line from core #10772

merged 25 commits into from
Feb 21, 2024

Conversation

nerdai
Copy link
Contributor

@nerdai nerdai commented Feb 16, 2024

Description

  • Part 2 of effort to remove core from CLI
  • Part 1, we prepared the llama-index-cli package
  • In this part, we remove command line from llama-index-core
  • NOTE: I've kept command_line/mappings.json as our download modules depends on this file to determine the package name for a class name (of a pack/tool/reader).
  • TODO in this PR:
    • build/publish new version of core with cli removed
    • update llama-index starter deps to update range of llama-index-core dep to ensure it uses versions with cli removed
    • update llama-index starter deps to include llama-index-cli package
    • update docs where we make mention of cli existing in core package

Type of Change

Please delete options that are not relevant.

  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • I stared at the code and made sure it makes sense

Sorry, something went wrong.

@dosubot dosubot bot added the size:XXL This PR changes 1000+ lines, ignoring generated files. label Feb 16, 2024

Verified

This commit was signed with the committer’s verified signature. The key has expired.
tonistiigi Tõnis Tiigi
@nerdai nerdai force-pushed the nerdai/rip-out-cli-pt2 branch from 11d93eb to 7d0fac9 Compare February 20, 2024 16:51

Verified

This commit was signed with the committer’s verified signature. The key has expired.
tonistiigi Tõnis Tiigi

Verified

This commit was signed with the committer’s verified signature. The key has expired.
tonistiigi Tõnis Tiigi

Verified

This commit was signed with the committer’s verified signature. The key has expired.
tonistiigi Tõnis Tiigi

Verified

This commit was signed with the committer’s verified signature. The key has expired.
tonistiigi Tõnis Tiigi

Verified

This commit was signed with the committer’s verified signature. The key has expired.
tonistiigi Tõnis Tiigi
@dosubot dosubot bot added size:XL This PR changes 500-999 lines, ignoring generated files. and removed size:XXL This PR changes 1000+ lines, ignoring generated files. labels Feb 20, 2024
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Feb 21, 2024
@nerdai nerdai merged commit 978cbac into main Feb 21, 2024
8 checks passed
@nerdai nerdai deleted the nerdai/rip-out-cli-pt2 branch February 21, 2024 02:15
Dominastorm pushed a commit to uptrain-ai/llama_index that referenced this pull request Feb 28, 2024
anoopshrma pushed a commit to anoopshrma/llama_index that referenced this pull request Mar 2, 2024
Izukimat pushed a commit to Izukimat/llama_index that referenced this pull request Mar 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm This PR has been approved by a maintainer size:XL This PR changes 500-999 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants