Feat/minio reader noverify #10744
Merged
Feat/minio reader noverify #10744
+9
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
the
size:XS
sansmoraxz
reviewed
Feb 15, 2024
| @@ -29,6 +29,7 @@ def __init__( | |||
| file_metadata: Optional[Callable[[str], Dict]] = None, | |||
| minio_endpoint: Optional[str] = None, | |||
| minio_secure: bool = False, | |||
| minio_cert_check: bool = False, | |||
There was a problem hiding this comment.
Shouldn't this be True by default as a security best practice?
There was a problem hiding this comment.
You're right. I'll fix that ASAP
dosubot
bot
added
size:S
|
the same feature was approved as a PR on llamahub about a couple of days ago. |
Dominastorm
pushed a commit
to uptrain-ai/llama_index
that referenced
this pull request
Feb 28, 2024
* allowing connection to a TLS-secured with untrusted certificate MinIO instance * updated README for MinIO reader * cert_check should default to True for MinIO reader --------- Co-authored-by: Ferdinando Simonetti <info@fsimonetti.info>
Izukimat
pushed a commit
to Izukimat/llama_index
that referenced
this pull request
Mar 29, 2024
* allowing connection to a TLS-secured with untrusted certificate MinIO instance * updated README for MinIO reader * cert_check should default to True for MinIO reader --------- Co-authored-by: Ferdinando Simonetti <info@fsimonetti.info>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The fix allows reading documents from a MinIO instance secured with TLS even if the instance's certificate isn't trusted.
It introduces
minio_cert_checkoption (defaulting to False, so running it against a self-signed MinIO will be fine).Type of Change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Suggested Checklist:
make format; make lintto appease the lint gods