feat: sync.EagerGroup #425
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sidddddarth
force-pushed
the
feat.syncGroup
branch
from
7b63556
to
502c049
Compare
Sidddddarth
requested review from
cisse21,
lvrach,
BonapartePC,
fracasula,
achettyiitr and
mihir20
lvrach
reviewed
Apr 10, 2024
Co-authored-by: Leonidas Vrachnis <leo.al.vra@gmail.com>
Co-authored-by: Leonidas Vrachnis <leo.al.vra@gmail.com>
fracasula
reviewed
Apr 11, 2024
lvrach
approved these changes
Apr 12, 2024
fracasula
approved these changes
Apr 12, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
EagerGroup
A sync group(
g.Go(f func() error)) that tries to not initialise new goroutines or running the function provided(f) if the context's cancelled.Otherwise works just like
golang.org/x/sync/errgroup.Use
NewEagerGroup(ctx, n)for a new eager group, panics otherwise.Limits only if
n > 0Bonus
Added github workflow concurrency groups as well.
Linear Ticket
< Replace_with_Linear_Link >
Security