Support encoding keyword in initialize (JRuby) #45
+14
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There appears to be no tests for this, but it was reported as missing behavior in jruby/jruby#7478. This change accepts the encoding keyword and sets it into the StringIO object, but uses of that encoding are still missing. In CRuby calls to the get_enc macro are used when reading from the StringIO, to encode the resulting Strings. These changes will come in a future commit.
|
@hsbt Has this repository been synced with the CRuby repository recently? |
|
@headius Yes, they are completely same files with ruby/ruby HEAD. |
|
@headius Should we merge this for a new release? |
|
Yes this can be merged and released. I had wanted to add some tests for the encoding behavior but never got around to it. |
|
Merging this was perhaps a little premature but it does not hurt anything and allows the encoding keyword to be passed without error. There's still work to be done to hook up the encoding to all of the I/O methods, but without tests for that behavior it's hard to know whether I'm implementing it right. In any case, I will handle the additional work myself and it's not necessary for this release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will add support for the
encodingkeyword toinitializein the JRuby extension.Unfortunately there appears to be no tests for this behavior, so adding some may have to be part of this work.