Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider BUNDLE_ONLY in cache key #531

Closed
r7kamura opened this issue Oct 3, 2023 · 3 comments · Fixed by #532
Closed

Consider BUNDLE_ONLY in cache key #531

r7kamura opened this issue Oct 3, 2023 · 3 comments · Fixed by #532

Comments

@r7kamura
Copy link
Contributor

r7kamura commented Oct 3, 2023

BUNDLE_ONLY has been added since bundler 2.3.19.

I think this value should be included in the cache key as well as BUNDLE_WITH and BUNDLE_WITHOUT, what do you think?

setup-ruby/bundler.js

Lines 235 to 239 in 52b8784

async function computeBaseKey(platform, engine, version, lockFile, cacheVersion) {
const cwd = process.cwd()
const bundleWith = process.env['BUNDLE_WITH'] || ''
const bundleWithout = process.env['BUNDLE_WITHOUT'] || ''
let key = `setup-ruby-bundler-cache-v6-${common.getOSNameVersionArch()}-${engine}-${version}-wd-${cwd}-with-${bundleWith}-without-${bundleWithout}`

@eregon
Copy link
Member

eregon commented Oct 3, 2023

Yes, that makes sense, could you make a PR for it?

@r7kamura
Copy link
Contributor Author

r7kamura commented Oct 3, 2023

Thanks for your quick reply. I created the following pull request for this 👌

@jlurena
Copy link

jlurena commented Feb 15, 2024

When will this be tagged?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging a pull request may close this issue.

3 participants