Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for macOS 13 machines #501

Merged
merged 4 commits into from Apr 24, 2023
Merged

Add support for macOS 13 machines #501

merged 4 commits into from Apr 24, 2023

Conversation

dfed
Copy link
Contributor

@dfed dfed commented Apr 24, 2023

Resolves #500

@dfed dfed mentioned this pull request Apr 24, 2023
Closed
eregon
eregon reviewed Apr 24, 2023
View reviewed changes
README.md Outdated Show resolved Hide resolved
eregon
eregon reviewed Apr 24, 2023
View reviewed changes
common.js Outdated Show resolved Hide resolved
dfed
dfed commented Apr 24, 2023
View reviewed changes
dist/index.js Show resolved Hide resolved
@eregon
Copy link
Member

eregon commented Apr 24, 2023

ruby-head doesn't seem to work on macos-13:
https://github.com/ruby/setup-ruby/actions/runs/4789926905/jobs/8518817787?pr=501

  /Users/runner/.rubies/ruby-head/bin/ruby --version
  dyld[45546]: Library not loaded: /usr/local/opt/capstone/lib/libcapstone.4.dylib
    Referenced from: <104F7475-BC65-3E02-A136-C0E500266ADC> /Users/runner/.rubies/ruby-head/bin/ruby
    Reason: tried: '/usr/local/opt/capstone/lib/libcapstone.4.dylib' (no such file), '/System/Volumes/Preboot/Cryptexes/OS/usr/local/opt/capstone/lib/libcapstone.4.dylib' (no such file), '/usr/local/opt/capstone/lib/libcapstone.4.dylib' (no such file), '/usr/local/lib/libcapstone.4.dylib' (no such file), '/usr/lib/libcapstone.4.dylib' (no such file, not in dyld cache)
  Took   0.04 seconds

@eregon
Copy link
Member

eregon commented Apr 24, 2023

I'll fix that separately, since it probably needs to be fixed in https://github.com/ruby/ruby-dev-builder anyway.

@eregon eregon merged commit 4d88f85 into ruby:master Apr 24, 2023
136 of 144 checks passed
eregon added a commit to ruby/ruby-dev-builder that referenced this pull request Apr 24, 2023
@eregon
Disable capstone as it causes ruby-head to fail on macos-13
228b62d 
* See ruby/setup-ruby#501 (comment)
k0kubun added a commit to ruby/ruby that referenced this pull request Apr 24, 2023
@k0kubun
Avoid linking capstone by default
0bf10df 
Workaround for ruby/setup-ruby#501 (comment)
@dfed dfed deleted the dfed--support-macos-13 branch April 24, 2023 19:59
@eregon
Copy link
Member

eregon commented Apr 24, 2023

That's fixed by ruby/ruby@0bf10df and just waiting https://github.com/ruby/ruby-dev-builder/actions/runs/4790510092/jobs/8519733847

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eregon eregon eregon left review comments

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Please support macOS 13
2 participants
@dfed @eregon