Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed benchmark target to Ruby latest #236

Merged
merged 1 commit into from
Jan 24, 2025

Conversation

naitoh
Copy link
Contributor

@naitoh naitoh commented Jan 22, 2025

Ruby 3.4 has been released, we will change our benchmark target to Ruby latest(3.4).

@naitoh naitoh marked this pull request as draft January 22, 2025 23:28
@@ -11,7 +11,7 @@ jobs:
fail-fast: false
matrix:
ruby-version:
- '3.3'
- '3.4'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can use 'ruby' if we always use the latest Ruby.

@naitoh naitoh changed the title Changed benchmark target to Ruby 3.4 Changed benchmark target to Ruby latest Jan 23, 2025
@naitoh naitoh force-pushed the update_parse_benchmark_ruby_3_4 branch from a417dea to 4dfe2c6 Compare January 23, 2025 14:02
Ruby 3.4 has been released, we will change our benchmark target to Ruby latest(3.4).

Co-authored-by: Sutou Kouhei <kou@clear-code.com>
@naitoh naitoh force-pushed the update_parse_benchmark_ruby_3_4 branch from 4dfe2c6 to 14b8159 Compare January 23, 2025 14:03
@naitoh naitoh marked this pull request as ready for review January 23, 2025 14:10
@naitoh naitoh requested a review from kou January 23, 2025 14:11
@kou kou merged commit f63c510 into ruby:master Jan 24, 2025
64 of 67 checks passed
@kou
Copy link
Member

kou commented Jan 24, 2025

Thanks.

@naitoh naitoh deleted the update_parse_benchmark_ruby_3_4 branch January 24, 2025 05:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants