Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix test target code of module_function #1316

Merged
merged 1 commit into from
Mar 16, 2025
Merged

Fix test target code of module_function #1316

merged 1 commit into from
Mar 16, 2025
+4 −4

Conversation

tompng
Copy link
Member

@tompng tompng commented Mar 16, 2025

The test target code was wrong. module_function is only available inside module, not inside class.

module_function is undefed in Class.

Class.undefined_instance_methods
=> [:prepend_features, :extend_object, :refine, :module_function, :append_features]

@tompng
Fix test target code of module_function

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Verified
Learn about vigilant mode
ef0b9c8 
module_function is only available inside module, not inside class.
kou
kou approved these changes Mar 16, 2025
View reviewed changes
Copy link
Member

@kou kou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@tompng tompng merged commit 56a28a1 into ruby:master Mar 16, 2025
30 checks passed
@tompng tompng deleted the module_function_test_fix branch March 16, 2025 11:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kou kou

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@tompng @kou