🔧 Add parser config for APPENDUID/COPYUID, 🗑️ Deprecate UIDPlusData
#401
+88
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This config attribute causes the parser to use the new AppendUIDData and CopyUIDData classes instead of CopyUIDData. AppendUIDData and CopyUIDData are _mostly_ backward-compatible with UIDPlusData. Most applications should be able to upgrade with no changes. UIDPlusData will be removed in +v0.6+.
nevans
force-pushed
the
config-deprecate-uidplus_data
branch
from
ec7fb2c to
13db788
Compare
|
Looks fine to me 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds
Net::IMAP::Config#parser_use_deprecated_uidplus_dataattribute. This config attribute causes the parser to use the new AppendUIDData and CopyUIDData classes instead of CopyUIDData.AppendUIDDataandCopyUIDDataare mostly backward-compatible withUIDPlusData. Most applications should be able to upgrade with no changes.The plan is to remove
UIDPlusDatainv0.6. To simplify upgrades, the config option can stay until0.7. But, afterUIDPlusDatahas been removed, maybe only allow setting it tofalse.