Gracefully handle incorrect command aliases #1059
Merged
+118
−24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Even if the aliased target is a helper method or does not exist, IRB should not crash. This commit warns users in such cases and treat the input as normal expression.
tompng
reviewed
Jan 4, 2025
tompng
reviewed
Jan 10, 2025
| message = <<~MESSAGE | ||
| Using command alias `#{command}` for helper method `#{aliased_name}` is not supported. | ||
| Please check the value of `IRB.conf[:COMMAND_ALIASES]`. | ||
| MESSAGE |
There was a problem hiding this comment.
How about moving this message generating part into IncorrectAlias and just return Statement::IncorrectAlias.new(aliased_name) here
There was a problem hiding this comment.
But that means we'll be querying registered helper methods from a Statement class, which IMO is a bad coupling. I think this type of interaction is better happen inside Context or Irb?
tompng
approved these changes
Jan 10, 2025
matzbot
pushed a commit
to ruby/ruby
that referenced
this pull request
Jan 10, 2025
(ruby/irb#1059) * Gracefully handle incorrect command aliases Even if the aliased target is a helper method or does not exist, IRB should not crash. This commit warns users in such cases and treat the input as normal expression. * Streamline command parsing and introduce warnings for incorrect command aliases ruby/irb@9fc14eb74b
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Even if the aliased target is a helper method or does not exist, IRB should not crash.
This commit warns users in such cases and treat the input as normal expression.
Fixes #992