Skip to content

Revert "Skip TypeCompletion test in ruby ci (#748)" #755

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 9, 2023
Merged

Revert "Skip TypeCompletion test in ruby ci (#748)" #755

merged 1 commit into from
Nov 9, 2023
+2 −11

Conversation

hsbt
Copy link
Member

@hsbt hsbt commented Nov 9, 2023

This reverts commit d394af0.

In ruby/ruby repository, we ignore to add .bundle path into $LOAD_PATH at ruby/ruby#8878. It seems fine with ruby/ruby#8879.

@hsbt
Revert "Skip TypeCompletion test in ruby ci (#748)"

Verified

This commit was signed with the committer’s verified signature.
ljharb Jordan Harband
GPG key ID: 9F6A681E35EF8B56
Verified
Learn about vigilant mode
0af3a08 
This reverts commit d394af0.
@tompng tompng merged commit a9d0145 into master Nov 9, 2023
@tompng tompng deleted the revert-rbs-guard branch November 9, 2023 12:45
matzbot pushed a commit to ruby/ruby that referenced this pull request Nov 9, 2023
@hsbt
[ruby/irb] Revert "Skip TypeCompletion test in ruby ci

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
GPG key ID: B5690EEEBB952194
Verified
Learn about vigilant mode
589e2b6 
(ruby/irb#748)"
(ruby/irb#755)

This reverts commit ruby/irb@d394af0bbce4.

ruby/irb@a9d0145115
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@st0012 st0012

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@hsbt @st0012 @tompng