Fix RubyLex test input to end with "\n". This change will also avoid truffleruby test failure. #614
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
st0012
approved these changes
Jun 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test in truffleruby was failing but CI passed.
See the
Run testssection in https://github.com/ruby/irb/actions/runs/5367916336/jobs/9738431555Problem
"\n"at the end of the input was missing."=begin"(not"=begin\n") will raisejava.lang.IndexOutOfBoundsException.eval('=begin') raises java.lang.IndexOutOfBoundsException oracle/truffleruby#3135
Code passed to termination proc always ends with
"\n". Code used to calculate dynamic_prompt and auto_indent also ends with"\n". But in test, input does not end with"\n".Fixing the test to use input more closer to real date will automatically avoid
"=begin"problem.Reason why CI passed
Test is run in
at_exit.Exit status of
ruby -e "at_exit{eval('=begin')}"for truffleruby is 0.