Sanitize non-option arguments passed to git name-rev

Author: jcouball

Diff for: lib/git/lib.rb

@@ -337,10 +337,22 @@ def rev_parse(revision)
     # For backwards compatibility with the old method name
     alias :revparse :rev_parse
 
-    def namerev(string)
-      command('name-rev', string).split[1]
+    # Find the first symbolic name for given commit_ish
+    #
+    # @param commit_ish [String] the commit_ish to find the symbolic name of
+    #
+    # @return [String, nil] the first symbolic name or nil if the commit_ish isn't found
+    #
+    # @raise [ArgumentError] if the commit_ish is a string starting with a hyphen
+    #
+    def name_rev(commit_ish)
+      assert_args_are_not_options('commit_ish', commit_ish)
+
+      command('name-rev', commit_ish).split[1]
     end
 
+    alias :namerev :name_rev
+
     def object_type(sha)
       command('cat-file', '-t', sha)
     end

Diff for: lib/git/object.rb

@@ -175,7 +175,7 @@ def message
       end
 
       def name
-        @base.lib.namerev(sha)
+        @base.lib.name_rev(sha)
       end
 
       def gtree

Diff for: tests/units/test_lib.rb

@@ -198,6 +198,16 @@ def test_rev_parse_with_unknown_revision
     end
   end
 
+  def test_name_rev
+    assert_equal('tags/v2.5~5', @lib.name_rev('00ea60e'))
+  end
+
+  def test_name_rev_with_invalid_commit_ish
+    assert_raise(ArgumentError) do
+      @lib.name_rev('-1cc8667014381')
+    end
+  end
+
   def test_object_type
     assert_equal('commit', @lib.object_type('1cc8667014381')) # commit
     assert_equal('tree', @lib.object_type('1cc8667014381^{tree}')) #tree