Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Naming/FileName check reports Rakefile.rb #12815

Closed
artur-intech opened this issue Apr 3, 2024 · 3 comments
Closed

Naming/FileName check reports Rakefile.rb #12815

artur-intech opened this issue Apr 3, 2024 · 3 comments
Labels
enhancement good first issue Easy task, suitable for newcomers to the project

Comments

@artur-intech
Copy link
Contributor

artur-intech commented Apr 3, 2024

My rake file is named Rakefile.rb and I get the following report:

rubocop Rakefile.rb
Inspecting 1 file
C

Offenses:

Rakefile.rb:1:1: C: Naming/FileName: The name of this source file (Rakefile.rb) should use snake_case.

Is there any reason why this is considered an issue? Rakefile.rb is the default filename among the others.

Why those filenames are not listed in the default config?

@bbatsov
Copy link
Collaborator

bbatsov commented Apr 3, 2024

Is there any reason why this is considered an issue? Rakefile.rb is the default filename among the others.

Not really a problem, just we hadn't accounted for. I guess we'll have to update the default config, as I was aware only of Rakefile and rakefile.rb.

@bbatsov bbatsov added the good first issue Easy task, suitable for newcomers to the project label Apr 3, 2024
@bbatsov
Copy link
Collaborator

bbatsov commented Apr 3, 2024

I see we also forgot to rename Exclude to AllowedNames/AllowedFileNames or something along those lines.

@koic
Copy link
Member

koic commented Apr 8, 2024

Fixed in #12816.

@koic koic closed this as completed Apr 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement good first issue Easy task, suitable for newcomers to the project
Projects
None yet
Development

No branches or pull requests

3 participants