Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add specs for Style/ArgumentsForwarding #12723

Merged
merged 1 commit into from Feb 29, 2024

Conversation

koic
Copy link
Member

@koic koic commented Feb 28, 2024

This PR adds specs for Style/ArgumentsForwarding, which adds missing tests due to the incorrect specification of TargetRubyVersion, addressing the current behavior that was lacking.


Before submitting the PR make sure the following are checked:

  • The PR relates to only one subject with a clear title and description in grammatically correct, complete sentences.
  • Wrote good commit messages.
  • Commit message starts with [Fix #issue-number] (if the related issue exists).
  • Feature branch is up-to-date with master (if not - rebase it).
  • Squashed related commits together.
  • Added tests.
  • Ran bundle exec rake default. It executes all tests and runs RuboCop on its own code.
  • Added an entry (file) to the changelog folder named {change_type}_{change_description}.md if the new code introduces user-observable changes. See changelog entry format for details.

This PR adds specs for `Style/ArgumentsForwarding`, which adds missing tests due to
the incorrect specification of `TargetRubyVersion`, addressing the current behavior that was lacking.
@koic koic merged commit b4cc305 into rubocop:master Feb 29, 2024
32 checks passed
@koic koic deleted the add_specs_for_style_arguments_forwarding branch February 29, 2024 02:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant