Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a false positive for Style/ArgumentsForwarding #12720

Conversation

koic
Copy link
Member

@koic koic commented Feb 28, 2024

This PR fixes a false positive for Style/ArgumentsForwarding when using block arg forwarding to within block with Ruby 3.3.0.

The following anonymous block parameter is also used within block (SyntaxError) occurs in Ruby 3.3.0:

$ cat example.rb
def baz(qux, quuz, &)
  with_block do
    bar(qux, quuz, &)
  end
end

$ ruby 3.3.0 (2023-12-25 revision 5124f9ac75) [x86_64-darwin22]
example.rb: example.rb:3: anonymous block parameter is also used within block (SyntaxError)

This fix is based on the following comment:
#12571 (comment)


Before submitting the PR make sure the following are checked:

  • The PR relates to only one subject with a clear title and description in grammatically correct, complete sentences.
  • Wrote good commit messages.
  • Commit message starts with [Fix #issue-number] (if the related issue exists).
  • Feature branch is up-to-date with master (if not - rebase it).
  • Squashed related commits together.
  • Added tests.
  • Ran bundle exec rake default. It executes all tests and runs RuboCop on its own code.
  • Added an entry (file) to the changelog folder named {change_type}_{change_description}.md if the new code introduces user-observable changes. See changelog entry format for details.

This PR fixes a false positive for `Style/ArgumentsForwarding`
when using block arg forwarding to within block with Ruby 3.3.0.

The following `anonymous block parameter is also used within block (SyntaxError)` occurs in Ruby 3.3.0:

```console
$ cat example.rb
def baz(qux, quuz, &)
  with_block do
    bar(qux, quuz, &)
  end
end

$ ruby 3.3.0 (2023-12-25 revision 5124f9ac75) [x86_64-darwin22]
example.rb: example.rb:3: anonymous block parameter is also used within block (SyntaxError)
```

This fix is based on the following comment:
rubocop#12571 (comment)
@bbatsov bbatsov merged commit 8aae48b into rubocop:master Feb 28, 2024
32 checks passed
@koic koic deleted the fix_a_false_positive_for_style_arguments_forwarding branch February 28, 2024 08:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants