Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

False negative for Layout/EmptyLineAfterMagicComment if file itself contains only comments #12710

Closed
Earlopain opened this issue Feb 25, 2024 · 0 comments · Fixed by #12764
Closed

False negative for Layout/EmptyLineAfterMagicComment if file itself contains only comments #12710

Earlopain opened this issue Feb 25, 2024 · 0 comments · Fixed by #12764

Comments

@Earlopain
Copy link
Contributor

Expected behavior

Offense for the following, this is somewhat common in rails initializers.

# frozen_string_literal: true
# Hello!

Actual behavior

No offense

RuboCop version

$ [bundle exec] rubocop -V
1.60.2 (using Parser 3.3.0.4, rubocop-ast 1.30.0, running on ruby 3.3.0) [x86_64-linux]
  - rubocop-performance 1.20.2
  - rubocop-rake 0.6.0
  - rubocop-rspec 2.26.1
Earlopain added a commit to Earlopain/rubocop that referenced this issue Mar 9, 2024
@Earlopain
[Fix rubocop#12710] Fix a false negative for `Layout/EmptyLineAfterMa…
5fb6047 
…gicComment` when the file is comments only
@Earlopain Earlopain mentioned this issue Mar 9, 2024
Merged
8 tasks
koic added a commit that referenced this issue Mar 9, 2024
@koic
Merge pull request #12764 from Earlopain/false-negative-for-layout-em…
167bad9 
…pty-line-after-magic-comment

[Fix #12710] Fix a false negative for `Layout/EmptyLineAfterMagicComment` when the file is comments only
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
1 participant
@Earlopain