Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add --editor-mode CLI option #12682

Merged
merged 1 commit into from Feb 12, 2024
Merged

Conversation

koic
Copy link
Member

@koic koic commented Feb 11, 2024

Follow up #12657 (comment).

This PR adds --editor-mode CLI option, which optimize real-time feedback in editors, adjusting behaviors for editing experience.

Editors that run RuboCop directly (e.g., by shelling out) encounter the same issues as with --lsp. This option is designed for such editors.


Before submitting the PR make sure the following are checked:

  • The PR relates to only one subject with a clear title and description in grammatically correct, complete sentences.
  • Wrote good commit messages.
  • Commit message starts with [Fix #issue-number] (if the related issue exists).
  • Feature branch is up-to-date with master (if not - rebase it).
  • Squashed related commits together.
  • Added tests.
  • Ran bundle exec rake default. It executes all tests and runs RuboCop on its own code.
  • Added an entry (file) to the changelog folder named {change_type}_{change_description}.md if the new code introduces user-observable changes. See changelog entry format for details.

Follow up rubocop#12657 (comment).

This PR adds `--editor-mode` CLI option, which optimize real-time feedback in editors,
adjusting behaviors for editing experience.

Editors that run RuboCop directly (e.g., by shelling out) encounter the same issues as with `--lsp`.
This option is designed for such editors.
@bbatsov bbatsov merged commit 1dac6a4 into rubocop:master Feb 12, 2024
32 checks passed
@bbatsov
Copy link
Collaborator

bbatsov commented Feb 12, 2024

Looks good to me. Thanks!

@koic koic deleted the add_editor_mode_option branch February 12, 2024 11:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants