Fix handling of textDocument/diagnostic #12664
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
textDocument
parameter for thetextDocument/diagnostic
request is of typeTextDocumentIdentifier
, which has a single propertyuri
of typeDocumentUri
.Ref: https://microsoft.github.io/language-server-protocol/specifications/lsp/3.17/specification/#textDocument_diagnostic
According to the spec the
DocumentUri
type does not hold the contents of the document, which the handler currently relies on in order to publish diagnostics to the client.This breaks the LSP mode in Neovim 0.10, which now supports pull diagnostics, and possibly other editors too. The same problem exists in
standardrb
(standardrb/standard#575)I have made the
textDocument/diagnostic
hander a no-op, since diagnostics are already being pushed to clients ontextDocument/didChange
.Let me know if you want to merge this in, and I'll add a changelog entry 馃憤