Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug on the Lint/SafeNavigationChain cop #12409

Closed
ydakuka opened this issue Nov 24, 2023 · 0 comments · Fixed by #12411
Closed

Bug on the Lint/SafeNavigationChain cop #12409

ydakuka opened this issue Nov 24, 2023 · 0 comments · Fixed by #12411
Labels

Comments

@ydakuka
Copy link

ydakuka commented Nov 24, 2023

Steps to reproduce the problem

I have the code:

def my_method
  User.find_by(value: value)
      &.includes(:enabled)
      .map(&:enabled)
      .compact
end

I run the command rubocop -A and get:

  def my_method
    User.find_by(value: value)
        &.includes(:enabled)&.
        .map(&:enabled)
        .compact
  end

RuboCop version

ydakuka@yauhenid:~/Work/project$ bin/rails_docker rubocop -V
1.57.2 (using Parser 3.2.2.4, rubocop-ast 1.29.0, running on ruby 2.7.8) [x86_64-linux]
  - rubocop-capybara 2.19.0
  - rubocop-factory_bot 2.24.0
  - rubocop-performance 1.19.1
  - rubocop-rails 2.22.0
  - rubocop-rake 0.6.0
  - rubocop-rspec 2.25.0
  - rubocop-thread_safety 0.5.1
@koic koic added the bug label Nov 24, 2023
koic added a commit to koic/rubocop that referenced this issue Nov 24, 2023
…tionChain`

Fixes rubocop#12409.

This PR fixes an incorrect autocorrect for `Lint/SafeNavigationChain`
when ordinary method chain exists after safe navigation leading dot method call.
koic added a commit that referenced this issue Nov 25, 2023
…t_safe_navigation_chain

[Fix #12409] Fix an incorrect autocorrect for `Lint/SafeNavigationChain`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants