Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

False negatives for Style/RedundantLineContinuation #12402

Closed
ydakuka opened this issue Nov 19, 2023 · 2 comments · Fixed by #12403
Closed

False negatives for Style/RedundantLineContinuation #12402

ydakuka opened this issue Nov 19, 2023 · 2 comments · Fixed by #12403
Labels

Comments

@ydakuka
Copy link

ydakuka commented Nov 19, 2023

Describe the solution you'd like

bad

let :user1 do
  create(:user, advertiser_type1, \
         advertiser: advertiser1, \
         user_type: user_type1)
end

let :user2 do
  build_stubbed(:user, advertiser_type2,
                advertiser: advertiser2, \
                user_type: user_type2)
end

def make_request
  patch api_v1_users_path(owner), \
        params: params, headers: headers
end

expect(page).to have_text \
  'Consequatur tenetur laboriosam necessitatibus. ' \
  'Qui architecto earum aliquid.'

good

let :user1 do
  create(:user, advertiser_type1,
         advertiser: advertiser1,
         user_type: user_type1)
end

let :user2 do
  build_stubbed(:user, advertiser_type2,
                advertiser: advertiser2,
                user_type: user_type2)
end

def make_request
  patch api_v1_users_path(owner),
        params: params, headers: headers
end

expect(page).to have_text \
  'Consequatur tenetur laboriosam necessitatibus. '
  'Qui architecto earum aliquid.'

Rubocop

ydakuka@yauhenid:~/Work/project$ bin/rails_docker rubocop -V
1.57.2 (using Parser 3.2.2.4, rubocop-ast 1.29.0, running on ruby 2.7.8) [x86_64-linux]
  - rubocop-capybara 2.19.0
  - rubocop-factory_bot 2.24.0
  - rubocop-performance 1.19.1
  - rubocop-rails 2.22.0
  - rubocop-rake 0.6.0
  - rubocop-rspec 2.25.0
  - rubocop-thread_safety 0.5.1
@ydah
Copy link
Member

ydah commented Nov 20, 2023

I think this should be a offense under Style/RedundantLineContinuation. (Assuming it is not already a offense at this time.)

@bquorning
Copy link
Contributor

I think this should be a offense under Style/RedundantLineContinuation. (Assuming it is not already a offense at this time.)

Agreed. I’ll transfer this issue from rubocop/rubocop-rspec to rubocop/rubocop.

@bquorning bquorning transferred this issue from rubocop/rubocop-rspec Nov 20, 2023
@bquorning bquorning changed the title Cop idea: a cop similar to the Style/RedundantLineContinuation False negatives for Style/RedundantLineContinuation Nov 20, 2023
@koic koic added the bug label Nov 21, 2023
koic added a commit to koic/rubocop that referenced this issue Nov 21, 2023
…nuation`

Fixes rubocop#12402.

This PR fixes false negatives for `Style/RedundantLineContinuation`
when redundant line continuations for a block are used,
especially without parentheses around first argument.
koic added a commit that referenced this issue Nov 22, 2023
…undant_line_continuation

[Fix #12402] Fix false negatives for `Style/RedundantLineContinuation`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants