Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Style/RedundantReturn cop for lambdas #12394

Closed
ydakuka opened this issue Nov 15, 2023 · 0 comments · Fixed by #12395
Closed

Improve Style/RedundantReturn cop for lambdas #12394

ydakuka opened this issue Nov 15, 2023 · 0 comments · Fixed by #12395
Labels

Comments

@ydakuka
Copy link

ydakuka commented Nov 15, 2023

Describe the solution you'd like

class User < ApplicationRecord
  # bad
  scope :my_scope_name, lambda {
    return my_method_name
  }

  # bad
  scope :my_scope_name1, -> { return my_method_name1 }
end

Rubocop

ydakuka@yauhenid:~/Work/project$ bin/rails_docker rubocop -V
1.57.2 (using Parser 3.2.2.4, rubocop-ast 1.29.0, running on ruby 2.7.8) [x86_64-linux]
  - rubocop-capybara 2.19.0
  - rubocop-factory_bot 2.24.0
  - rubocop-performance 1.19.1
  - rubocop-rails 2.22.0
  - rubocop-rake 0.6.0
  - rubocop-rspec 2.25.0
  - rubocop-thread_safety 0.5.1
@ydakuka ydakuka changed the title Improve Style/RedundantReturn cop Improve Style/RedundantReturn cop for lambdas Nov 15, 2023
@koic koic added the bug label Nov 16, 2023
koic added a commit to koic/rubocop that referenced this issue Nov 16, 2023
Fixes rubocop#12394.

This PR fixes false negatives for `Style/RedundantReturn`
when `lambda`, `->`, or `proc` ending with `return`.
koic added a commit that referenced this issue Nov 16, 2023
…undant_return

[Fix #12394] Fix false negatives for `Style/RedundantReturn`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants