Invalid autocorrect for Style/HashSyntax

[jcoyne]

This was a String format operator, but it gets transformed to be a String quotation.

Offenses:

app/helpers/application_helper.rb:36:37: C: [Corrected] Style/HashSyntax: Omit the hash value.
      Settings.embed.url % { druid: druid }
                                    ^^^^^

40 files inspected, 1 offense detected, 1 offense corrected

➜  git diff
diff --git a/app/helpers/application_helper.rb b/app/helpers/application_helper.rb
index 5809493..5468147 100644
--- a/app/helpers/application_helper.rb
+++ b/app/helpers/application_helper.rb
@@ -33,7 +33,7 @@ module ApplicationHelper

   def embeddable_url(druid)
     if Settings.embed.url
-      Settings.embed.url % { druid: druid }
+      Settings.embed.url %({ druid: })
     else
       purl_url(druid)


➜  bundle exec  rubocop -v
1.56.2

[koic]

I cannot reproduce that issue. If only the Style/HashSyntax registering offenses, can you provide your .rubocop.yml configuration?

[jcoyne]

Yes:
https://github.com/sul-dlss/purl/blob/main/.rubocop.yml

• https://github.com/sul-dlss/purl/blob/main/.rubocop_todo.yml

You can reproduce by pulling this commit: sul-dlss/purl@c12d669 then changing the ruby language to 3.2 and then autocorrecting with rubocop.

[jcoyne]

Here's a minimal test case:

# test.rb
if Settings.embed.url
  Settings.embed.url % { druid: druid }
else
  purl_url(druid)
end

# .rubocop.yml
AllCops:
  TargetRubyVersion: 3.2

Style/FrozenStringLiteralComment:
  Enabled: false

Style/FormatString:
  Enabled: false