Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Style/RedundantParentheses cop #12311

Closed
ydakuka opened this issue Oct 25, 2023 · 0 comments · Fixed by #12368
Closed

Improve Style/RedundantParentheses cop #12311

ydakuka opened this issue Oct 25, 2023 · 0 comments · Fixed by #12368

Comments

@ydakuka
Copy link

ydakuka commented Oct 25, 2023

Code

class UserPolicy < ApplicationPolicy
  # bad
  def user_read_authorized?
    (
      my_method1 || my_method2
    )
  end

  # good
  def user_read_authorized?
    my_method1 || my_method2
  end
end

terminal:

ydakuka@yauhenid:~/Work/project$ bin/rails_docker rubocop app/policies/user_policy.rb 
Inspecting 1 file
.

1 file inspected, no offenses detected

Rubocop

ydakuka@yauhenid:~/Work/project$ bin/rails_docker rubocop -V
1.57.1 (using Parser 3.2.2.4, rubocop-ast 1.29.0, running on ruby 2.7.8) [x86_64-linux]
  - rubocop-capybara 2.19.0
  - rubocop-factory_bot 2.24.0
  - rubocop-performance 1.19.1
  - rubocop-rails 2.21.1
  - rubocop-rake 0.6.0
  - rubocop-rspec 2.24.1
  - rubocop-thread_safety 0.5.1
koic added a commit to koic/rubocop that referenced this issue Nov 8, 2023
Fixes rubocop#12311.

This PR fixes false negatives for `Style/RedundantParentheses`
when parentheses around logical operator keywords in method definition.
bbatsov pushed a commit that referenced this issue Nov 9, 2023
Fixes #12311.

This PR fixes false negatives for `Style/RedundantParentheses`
when parentheses around logical operator keywords in method definition.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants