Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Style/RedundantFilterChain cop #12301

Closed
ydakuka opened this issue Oct 21, 2023 · 0 comments · Fixed by #12302
Closed

Improve Style/RedundantFilterChain cop #12301

ydakuka opened this issue Oct 21, 2023 · 0 comments · Fixed by #12302

Comments

@ydakuka
Copy link

ydakuka commented Oct 21, 2023

The cop does not take into account the &. operator.

Code

module ApplicationHelper
  # bad
  def my_method
    [1, 2, 3]&.select { |num| num == 3 }&.any?
  end

  # good
  def my_method
    [1, 2, 3]&.any? { |num| num == 3 }
  end
end

Rubocop

ydakuka@yauhenid:~/Work/project$ bin/rails_docker rubocop -V
1.57.1 (using Parser 3.2.2.4, rubocop-ast 1.29.0, running on ruby 2.7.8) [x86_64-linux]
  - rubocop-capybara 2.19.0
  - rubocop-factory_bot 2.24.0
  - rubocop-performance 1.19.1
  - rubocop-rails 2.21.1
  - rubocop-rake 0.6.0
  - rubocop-rspec 2.24.1
  - rubocop-thread_safety 0.5.1
koic added a commit to koic/rubocop that referenced this issue Oct 21, 2023
…avigation

Fixes rubocop#12301.

This PR makes `Style/RedundantFilterChain` aware of safe navigation.
koic added a commit that referenced this issue Oct 22, 2023
…_aware_of_safe_navigation

[Fix #12301] Make `Style/RedundantFilterChain` aware of safe navigation
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants