Style/ClassEqualityComparison autocorrect is not safe #12097
Labels
Comments
koic
added a commit
to koic/rubocop
that referenced
this issue
Aug 10, 2023
…omparison` Fixes rubocop#12097. This PR marks unsafe autocorrect for `Style/ClassEqualityComparison` because there is no guarantee that the constant `Foo` exists when autocorrecting `var.class.name == 'Foo'` to `var.instance_of?(Foo)`.
8 tasks
bbatsov
pushed a commit
that referenced
this issue
Sep 28, 2023
Fixes #12097. This PR marks unsafe autocorrect for `Style/ClassEqualityComparison` because there is no guarantee that the constant `Foo` exists when autocorrecting `var.class.name == 'Foo'` to `var.instance_of?(Foo)`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
It is not safe to autocorrect
foo.class.name == 'Bar'tofoo.instance_of?(::Bar)because::Barmay not be defined.Expected behavior
The Style/ClassEqualityComparison cop autocorrect shouldn't be marked as safe because the autocorrected code may cause
NameError.Actual behavior
foo.class.name == 'Bar'is autocorrected tofoo.instance_of?(::Bar).Steps to reproduce the problem
Create a file with
foo.class.name == 'Bar'and runrubocop -a.RuboCop version
1.55.1
The text was updated successfully, but these errors were encountered: