Layout/ClosingHeredocIndentation & Style/RedundantHeredocDelimiterQuotes - undefined method `captures' for nil:NilClass

[snutij]

Hello 👋 I open an issue for both cops, because it failed on the same method heredoc_type do not hesitate to tell me if you prefer two distinct issues.

Given a file foo.rb:

<<""

Which is a valid syntax:

ruby -c foo.rb
Syntax OK

---

Expected behavior

Should not trigger an error. I think this is a valid heredoc syntax, as it start with << maybe some related offenses can be displayed. I'm very terrible with regex, so I can't dig more on group expectation etc. 😞

Actual behavior

bin/rubocop -d --only Style/RedundantHeredocDelimiterQuotes foo.rb

An error occurred while Style/RedundantHeredocDelimiterQuotes cop was inspecting foo.rb:1:0.
undefined method `captures' for nil:NilClass
/Users/snutij/.rbenv/versions/3.2.2/lib/ruby/gems/3.2.0/gems/rubocop-1.53.1/lib/rubocop/cop/mixin/heredoc.rb:34:in `heredoc_type'
/Users/snutij/.rbenv/versions/3.2.2/lib/ruby/gems/3.2.0/gems/rubocop-1.53.1/lib/rubocop/cop/style/redundant_heredoc_delimiter_quotes.rb:49:in `need_heredoc_delimiter_quotes?'
/Users/snutij/.rbenv/versions/3.2.2/lib/ruby/gems/3.2.0/gems/rubocop-1.53.1/lib/rubocop/cop/style/redundant_heredoc_delimiter_quotes.rb:37:in `on_heredoc'
/Users/snutij/.rbenv/versions/3.2.2/lib/ruby/gems/3.2.0/gems/rubocop-1.53.1/lib/rubocop/cop/mixin/heredoc.rb:12:in `on_str'
/Users/snutij/.rbenv/versions/3.2.2/lib/ruby/gems/3.2.0/gems/rubocop-1.53.1/lib/rubocop/cop/commissioner.rb:107:in `public_send'

bin/rubocop -d --only Style/ClosingHeredocIndentation foo.rb

An error occurred while Layout/ClosingHeredocIndentation cop was inspecting foo.rb:1:0.
undefined method `captures' for nil:NilClass
/Users/snutij/.rbenv/versions/3.2.2/lib/ruby/gems/3.2.0/gems/rubocop-1.53.1/lib/rubocop/cop/mixin/heredoc.rb:34:in `heredoc_type'
/Users/snutij/.rbenv/versions/3.2.2/lib/ruby/gems/3.2.0/gems/rubocop-1.53.1/lib/rubocop/cop/layout/closing_heredoc_indentation.rb:59:in `on_heredoc'
/Users/snutij/.rbenv/versions/3.2.2/lib/ruby/gems/3.2.0/gems/rubocop-1.53.1/lib/rubocop/cop/mixin/heredoc.rb:12:in `on_str'
/Users/snutij/.rbenv/versions/3.2.2/lib/ruby/gems/3.2.0/gems/rubocop-1.53.1/lib/rubocop/cop/commissioner.rb:107:in `public_send'

Steps to reproduce the problem

Both Layout/ClosingHeredocIndentation & Style/RedundantHeredocDelimiterQuotes are using the heredoc_type method from the module RuboCop::Cop::Heredoc

Which receive a node:

(rdbg) node
s(:dstr)
(ruby) node.source
"<<\"\""

Nothing match with the pattern:
OPENING_DELIMITER = /(<<[~-]?)['"`]?([^'"`]+)['"`]?/.freeze

(ruby) node.source.match(OPENING_DELIMITER)
nil

So the capture group node.source.match(OPENING_DELIMITER).captures[0] trigger an error.

rubocop/lib/rubocop/cop/layout/closing_heredoc_indentation.rb

Lines 57 to 66 in aaf1c3f

	def on_heredoc(node)
	return if heredoc_type(node) == SIMPLE_HEREDOC ||
	opening_indentation(node) == closing_indentation(node) ||
	argument_indentation_correct?(node)
	message = message(node)
	add_offense(node.loc.heredoc_end, message: message) do |corrector|
	corrector.replace(node.loc.heredoc_end, indented_end(node))
	end
	end

rubocop/lib/rubocop/cop/style/redundant_heredoc_delimiter_quotes.rb

Lines 48 to 54 in aaf1c3f

	def need_heredoc_delimiter_quotes?(node)
	heredoc_delimiter = node.source.delete(heredoc_type(node))
	return true unless heredoc_delimiter.start_with?("'", '"')
	node.loc.heredoc_end.source.strip.match?(/\W/) ||
	node.loc.heredoc_body.source.match?(STRING_INTERPOLATION_OR_ESCAPED_CHARACTER_PATTERN)
	end

rubocop/lib/rubocop/cop/mixin/heredoc.rb

Lines 32 to 34 in aaf1c3f

	def heredoc_type(node)
	node.source.match(OPENING_DELIMITER).captures[0]
	end

RuboCop version

bundle exec rubocop -V
1.53.1 (using Parser 3.2.2.3, rubocop-ast 1.29.0, running on ruby 3.2.2) [arm64-darwin22]
  - rubocop-minitest 0.31.0
  - rubocop-rake 0.6.0
  - rubocop-sorbet 0.7.0

[AlexWayfer]

This can be relevant: #12013

Or this: rubocop/rubocop-rspec#1667