Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support for pass-blocks in Style/MapToHash and StyleMapToSet #11732

Closed
vlad-pisanov opened this issue Mar 24, 2023 · 0 comments · Fixed by #11735
Closed

Support for pass-blocks in Style/MapToHash and StyleMapToSet #11732

vlad-pisanov opened this issue Mar 24, 2023 · 0 comments · Fixed by #11735
Labels
enhancement

Comments

@vlad-pisanov
Copy link

Enhancement: currently, Style/MapToHash and StyleMapToSet only detect and autocorrect explicit blocks, but the same approach should work for pass-blocks as well:

# Before
list.map(&:foo).to_h
list.map(&:foo).to_set

# After
list.to_h(&:foo)
list.to_set(&:foo)
koic added a commit to koic/rubocop that referenced this issue Mar 24, 2023
@koic
[Fix rubocop#11732] Make Style/MapToHash and Style/MapToSet aware…
95e374d 
… of symbol proc

Fixes rubocop#11732.

This PR makes `Style/MapToHash` and `Style/MapToSet` aware of symbol proc.
@koic koic mentioned this issue Mar 24, 2023
Merged
8 tasks
bbatsov pushed a commit that referenced this issue Mar 25, 2023
@koic @bbatsov
[Fix #11732] Make Style/MapToHash and Style/MapToSet aware of sym…
5d98bd8 
…bol proc

Fixes #11732.

This PR makes `Style/MapToHash` and `Style/MapToSet` aware of symbol proc.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Fix #11732] Make Style/MapToHash and Style/MapToSet aware of symbol proc koic/rubocop
2 participants
@koic @vlad-pisanov