Lint/Syntax is suppressed when using the "--only" flag #11697
Labels
Comments
koic
added a commit
to koic/rubocop
that referenced
this issue
Mar 24, 2023
…tion Fixes rubocop#11697. This PR fixes `Lint/Syntax` behavior when `--only` is not given the cop name. The cop must always be executed.
8 tasks
bbatsov
pushed a commit
that referenced
this issue
Mar 25, 2023
Fixes #11697. This PR fixes `Lint/Syntax` behavior when `--only` is not given the cop name. The cop must always be executed.
camilopayan
added a commit
to standardrb/standard
that referenced
this issue
Apr 19, 2023
You can watch this get configured live! https://www.youtube.com/watch?v=8rLe_qmH84k This also fixes a test that broke when [this issue in Rubocop for Lint/Syntax was fixed](rubocop/rubocop#11697). Co-authored-by: Daniel Huss <daniel.huss@testdouble.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
When running rubocop for a specific cop using the
--onlyflag on a specific file, and that file has syntax errors. Rubocop$? -eq 0This is counter-intuitive because rubocop cannot successfully parse the file to actually check the cop requested. So it should be a failure.
I would suggest that
Lint/Syntaxshould always be reported even when the--onlyflag is used. Maybe internally always prepend--only <list>withLint/Syntax?rubocop --version
1.28.2 (latest for ruby 2.5)
The text was updated successfully, but these errors were encountered: