Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #11658: registers pry as an offense #11669

Merged
merged 2 commits into from Mar 13, 2023
Merged

Fix #11658: registers pry as an offense #11669

merged 2 commits into from Mar 13, 2023

Conversation

ThHareau
Copy link
Contributor

@ThHareau ThHareau commented Mar 6, 2023

Fix for #11658 : pry alone is now an offense

Before submitting the PR make sure the following are checked:

  • The PR relates to only one subject with a clear title and description in grammatically correct, complete sentences.
  • Wrote good commit messages.
  • Commit message starts with [Fix #issue-number] (if the related issue exists).
  • Feature branch is up-to-date with master (if not - rebase it).
  • Squashed related commits together.
  • Added tests.
  • Ran bundle exec rake default. It executes all tests and runs RuboCop on its own code.
  • Added an entry (file) to the changelog folder named {change_type}_{change_description}.md if the new code introduces user-observable changes. See changelog entry format for details.

@ThHareau ThHareau marked this pull request as ready for review March 6, 2023 11:22
@ThHareau
Copy link
Contributor Author

ThHareau commented Mar 6, 2023

I'm not sure why the CircleCI pipeline is failing.

Also, is it a breaking change? It it breaking for sure, as people would not be able to allow pry anymore, but I'm not sure if it's enough to flag it as breaking?

@vlad-pisanov
Copy link

@ThHareau your CI run just needs to be approved by the repo maintainer 🙂

@koic
Copy link
Member

koic commented Mar 7, 2023

CircleCI's support team's response seems to require re-authentication to CircleCI.

Contributors who get this error need to re-authenticate with CircleCI because their GitHub OAuth token has expired.

https://support.circleci.com/hc/en-us/articles/360051228052-How-to-Perform-a-Re-Authentication

@ThHareau
Copy link
Contributor Author

ThHareau commented Mar 7, 2023

@koic I don't have a CircleCI account, is that necessary to run the CI?

I'm trying to register, but it seems broken :/

@bbatsov bbatsov merged commit ed786ab into rubocop:master Mar 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants