From 0d5b4d2b85ff54c09c99ceabf5bdfedab48e3dc8 Mon Sep 17 00:00:00 2001
From: ydah <t.yudai92@gmail.com>
Date: Sat, 2 Mar 2024 03:27:46 +0900
Subject: [PATCH] Add test case for `RSpec/RepeatedSubjectCall`

---
 .../cop/rspec/repeated_subject_call_spec.rb   | 49 +++++++++++++++----
 1 file changed, 40 insertions(+), 9 deletions(-)

diff --git a/spec/rubocop/cop/rspec/repeated_subject_call_spec.rb b/spec/rubocop/cop/rspec/repeated_subject_call_spec.rb
index 514c9893c..2c11c3e0f 100644
--- a/spec/rubocop/cop/rspec/repeated_subject_call_spec.rb
+++ b/spec/rubocop/cop/rspec/repeated_subject_call_spec.rb
@@ -1,7 +1,7 @@
 # frozen_string_literal: true
 
 RSpec.describe RuboCop::Cop::RSpec::RepeatedSubjectCall do
-  it 'registers an offense for a singular block' do
+  it 'registers an offense when a singular block' do
     expect_offense(<<-RUBY)
       RSpec.describe Foo do
         it do
@@ -13,7 +13,7 @@
     RUBY
   end
 
-  it 'registers an offense for repeated blocks' do
+  it 'registers an offense when repeated blocks' do
     expect_offense(<<-RUBY)
       RSpec.describe Foo do
         it do
@@ -25,7 +25,7 @@
     RUBY
   end
 
-  it 'registers an offense for nested blocks' do
+  it 'registers an offense when nested blocks' do
     expect_offense(<<-RUBY)
       RSpec.describe Foo do
         it do
@@ -39,7 +39,7 @@
     RUBY
   end
 
-  it 'registers an offense for custom subjects' do
+  it 'registers an offense when custom subjects' do
     expect_offense(<<-RUBY)
       RSpec.describe Foo do
         subject(:bar) { do_something }
@@ -53,7 +53,7 @@
     RUBY
   end
 
-  it 'registers no offenses for no block' do
+  it 'does not register an offense when no block' do
     expect_no_offenses(<<~RUBY)
       RSpec.describe Foo do
         it do
@@ -64,7 +64,7 @@
     RUBY
   end
 
-  it 'registers no offenses for block first' do
+  it 'does not register an offense when block first' do
     expect_no_offenses(<<~RUBY)
       RSpec.describe Foo do
         it do
@@ -75,7 +75,7 @@
     RUBY
   end
 
-  it 'registers no offenses for different subjects' do
+  it 'does not register an offense when different subjects' do
     expect_no_offenses(<<-RUBY)
       RSpec.describe Foo do
         subject { do_something_else }
@@ -89,7 +89,7 @@
     RUBY
   end
 
-  it 'registers no offenses for multiple no description it blocks' do
+  it 'does not register an offense when multiple no description it blocks' do
     expect_no_offenses(<<-RUBY)
       RSpec.describe Foo do
         it do
@@ -103,7 +103,7 @@
     RUBY
   end
 
-  it 'registers no offenses for `subject.method_call`' do
+  it 'does not register an offense when `subject.method_call`' do
     expect_no_offenses(<<~RUBY)
       RSpec.describe Foo do
         it do
@@ -113,4 +113,35 @@
       end
     RUBY
   end
+
+  it 'does not register an offense when `subject` with not expectation' do
+    expect_no_offenses(<<~RUBY)
+      RSpec.describe Foo do
+        it do
+          allow(Foo).to receive(:bar).and_return(subject)
+          allow(Foo).to receive(:bar) { subject }
+        end
+      end
+    RUBY
+  end
+
+  it 'does not register an offense when `subject` not inside example' do
+    expect_no_offenses(<<~RUBY)
+      RSpec.describe Foo do
+        subject { do_something }
+
+        it do
+          expect { subject }.to change { Foo.count }
+        end
+      end
+    RUBY
+  end
+
+  it 'does not register an offense when `subject` is not inside describe' do
+    expect_no_offenses(<<~RUBY)
+      Foo.subject(:bar)
+      subject(:bar)
+      subject
+    RUBY
+  end
 end