Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix bug with range in RepeatedIncludeExample cop #1867

Merged
merged 1 commit into from
Apr 7, 2024
Merged

Fix bug with range in RepeatedIncludeExample cop #1867

merged 1 commit into from
Apr 7, 2024

Conversation

hasghari
Copy link
Contributor

@hasghari hasghari commented Apr 6, 2024 •
edited

Fixes issue #1866

Before submitting the PR make sure the following are checked:

  • Feature branch is up-to-date with master (if not - rebase it).
  • Squashed related commits together.
  • Added tests.
  • Updated documentation.
  • Added an entry to the CHANGELOG.md if the new code introduces user-observable changes.
  • The build (bundle exec rake) passes (be sure to run this locally, since it may produce updated documentation that you will need to commit).

@hasghari hasghari requested a review from a team as a code owner April 6, 2024 12:50
ydah
ydah reviewed Apr 6, 2024
View reviewed changes
Copy link
Member

@ydah ydah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add an entry to the CHANGELOG.md ?

@hasghari
Copy link
Contributor Author

hasghari commented Apr 7, 2024

@ydah I've added the changelog entry.

ydah
ydah reviewed Apr 7, 2024
View reviewed changes
Copy link
Member

@ydah ydah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks failed for rspec. Could you fixes failed tests?

@bquorning
Copy link
Collaborator

If you run bundle exec rake locally, it will tell you what to do (hint: put a link to your GitHub profile at the bottom of Changelog)

@bquorning
Copy link
Collaborator

bquorning commented Apr 7, 2024 •
edited

@ydah Do you know why mdformat is failing?

@hasghari
Copy link
Contributor Author

hasghari commented Apr 7, 2024

Thanks for the tip, I've fixed the changelog.

@bquorning bquorning merged commit 7b2884e into rubocop:master Apr 7, 2024
24 checks passed
@hasghari hasghari deleted the range-bug branch April 7, 2024 13:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ydah ydah ydah left review comments

@bquorning bquorning bquorning approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@hasghari @bquorning @ydah