Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump to v2.29.1 #1863

Merged
merged 1 commit into from Apr 4, 2024
Merged

Bump to v2.29.1 #1863

merged 1 commit into from Apr 4, 2024

Conversation

bquorning
Copy link
Collaborator

@bquorning bquorning commented Apr 4, 2024 •
edited

Before submitting the PR make sure the following are checked:

  • Feature branch is up-to-date with master (if not - rebase it).
  • Squashed related commits together.
  • Added tests.
  • Updated documentation.
  • Added an entry to the CHANGELOG.md if the new code introduces user-observable changes.
  • The build (bundle exec rake) passes (be sure to run this locally, since it may produce updated documentation that you will need to commit).

@bquorning bquorning marked this pull request as ready for review April 4, 2024 22:27
@bquorning bquorning requested a review from a team as a code owner April 4, 2024 22:27
@bquorning bquorning requested a review from ydah April 4, 2024 22:28
ydah
ydah approved these changes Apr 4, 2024
View reviewed changes
Copy link
Member

@ydah ydah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅

@ydah ydah merged commit d022102 into master Apr 4, 2024
24 checks passed
@ydah ydah deleted the release branch April 4, 2024 22:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ydah ydah ydah approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@bquorning @ydah