Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add VersionAdd for RSpec/EmptyOutput #1861

Merged
merged 1 commit into from Apr 4, 2024
Merged

Add VersionAdd for RSpec/EmptyOutput #1861

merged 1 commit into from Apr 4, 2024

Conversation

ydah
Copy link
Member

@ydah ydah commented Apr 4, 2024


Before submitting the PR make sure the following are checked:

  • Feature branch is up-to-date with master (if not - rebase it).
  • Squashed related commits together.
  • [-] Added tests.
  • [-] Updated documentation.
  • Added an entry to the CHANGELOG.md if the new code introduces user-observable changes.
  • The build (bundle exec rake) passes (be sure to run this locally, since it may produce updated documentation that you will need to commit).

@ydah ydah requested a review from a team as a code owner April 4, 2024 22:19
@bquorning
Copy link
Collaborator

Yeah, I noticed that also, too late. We should probably add a CI check so we don’t miss it in the future.

@bquorning bquorning merged commit 9bdc63b into master Apr 4, 2024
24 checks passed
@bquorning bquorning deleted the follow branch April 4, 2024 22:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants