Add test to ensure unsafe cops are properly configured #1842
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I noticed that our specs are flaky, and git-bisect tells me it happened after this PR. Here’s a minimal failing spec run: bundle exec rspec './spec/project/default_config_spec.rb[1:8]' './spec/rubocop/rspec/description_extractor_spec.rb[1:1]' --seed=28987 |
|
@bquorning Thank you. I fixed it: #1855 |
ydah
added a commit
to rubocop/rubocop-capybara
that referenced
this pull request
Apr 10, 2024
4 tasks
ydah
added a commit
to rubocop/rubocop-rspec_rails
that referenced
this pull request
Apr 10, 2024
4 tasks
ydah
added a commit
to rubocop/rubocop-factory_bot
that referenced
this pull request
Apr 10, 2024
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up: rubocop/rubocop@7cda5ae
Before submitting the PR make sure the following are checked:
master(if not - rebase it).CHANGELOG.mdif the new code introduces user-observable changes.bundle exec rake) passes (be sure to run this locally, since it may produce updated documentation that you will need to commit).