Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use 'registers no offense' instead of 'register no offense' #1839

Merged
merged 1 commit into from Mar 21, 2024

Conversation

ydah
Copy link
Member

@ydah ydah commented Mar 21, 2024

This PR use 'registers no offense' instead of 'register no offense'
Follow up: rubocop/rubocop#12779


Before submitting the PR make sure the following are checked:

  • Feature branch is up-to-date with master (if not - rebase it).
  • Squashed related commits together.
  • [-] Added tests.
  • [-] Updated documentation.
  • [-] Added an entry to the CHANGELOG.md if the new code introduces user-observable changes.
  • The build (bundle exec rake) passes (be sure to run this locally, since it may produce updated documentation that you will need to commit).

This PR use 'registers no offense' instead of 'register no offense'
Follow up: rubocop/rubocop#12779
@ydah ydah marked this pull request as ready for review March 21, 2024 08:24
@ydah ydah requested a review from a team as a code owner March 21, 2024 08:24
@pirj pirj merged commit ecd945f into master Mar 21, 2024
24 checks passed
@pirj pirj deleted the use-registers-no-offense branch March 21, 2024 08:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants