Fix a false positive for RSpec/RepeatedSubjectCall

[ydah]

Fix: #1821

---

Before submitting the PR make sure the following are checked:

• Feature branch is up-to-date with master (if not - rebase it).
• Squashed related commits together.
• Added tests.
• Updated documentation.
• Added an entry to the CHANGELOG.md if the new code introduces user-observable changes.
• The build (bundle exec rake) passes (be sure to run this locally, since it may produce updated documentation that you will need to commit).

[pirj]

A nice simplification and a quick fix. Thank you!

[pirj]

I have never seen this method. Is it old enough for us to be sure it will be there with a minimum required rubocop and rubocop-ast versions we require?

[Darhazer]

It was there like forever. I just wonder if we should not just skip the whole each_ancestor in this case, instead of skipping each iteration 😅

[ydah]

we should not just skip the whole each_ancestor in this case, instead of skipping each iteration 😅

Indeed! Thank you catching this.

[Darhazer]

I have no objections against this change.

The original spec however is light on use cases. What happens for instance if you access subject in a hook, let's say configuring a stub like allow(Foo).to receive(:bar).and_return(subject) (which might also use block synax allow(Foo).to receive(:bar) { subject }. It's hard to tell from reading the code alone

[ydah]

The original spec however is light on use cases. What happens for instance if you access subject in a hook, let's say configuring a stub like allow(Foo).to receive(:bar).and_return(subject) (which might also use block synax allow(Foo).to receive(:bar) { subject }. It's hard to tell from reading the code alone

Indeed. I'll make a follow-up PR.