Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve for project_spec #1721

Merged
merged 2 commits into from
Sep 19, 2023
Merged

Improve for project_spec #1721

merged 2 commits into from
Sep 19, 2023

Conversation

ydah
Copy link
Member

@ydah ydah commented Sep 15, 2023

This PR is improve for project_spec

  • Fix the fact that entries was always an empty array and always succeeded because the format was changed by 4874a5a
  • Add a test to check that there are no consecutive whitespace characters in the CHANGELOG

Before submitting the PR make sure the following are checked:

  • Feature branch is up-to-date with master (if not - rebase it).
  • Squashed related commits together.
  • Added tests.
  • Updated documentation.
  • [-] Added an entry to the CHANGELOG.md if the new code introduces user-observable changes.
  • The build (bundle exec rake) passes (be sure to run this locally, since it may produce updated documentation that you will need to commit).

pirj
pirj approved these changes Sep 15, 2023
View reviewed changes
Copy link
Member

@pirj pirj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!
Does it make sense to add the commit to that file that would tell GitHub to ignore it for blame?

bquorning
bquorning reviewed Sep 16, 2023
View reviewed changes
spec/project/changelog_spec.rb Outdated Show resolved Hide resolved
spec/project/changelog_spec.rb Show resolved Hide resolved
spec/project/changelog_spec.rb Outdated Show resolved Hide resolved
@ydah ydah requested a review from bquorning September 19, 2023 11:19
bquorning
bquorning approved these changes Sep 19, 2023
View reviewed changes
Copy link
Collaborator

@bquorning bquorning left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you 🙏🏼

@ydah ydah merged commit 865ea17 into master Sep 19, 2023
22 checks passed
@ydah ydah deleted the fix-project-spec branch September 19, 2023 11:51
@ydah ydah mentioned this pull request Sep 19, 2023
Merged
4 tasks
ydah added a commit to rubocop/rubocop-factory_bot that referenced this pull request Sep 19, 2023
@ydah
Improve for project_spec
42eecf0 
Follow up: rubocop/rubocop-rspec#1721
@ydah ydah mentioned this pull request Sep 19, 2023
Merged
4 tasks
ydah added a commit to rubocop/rubocop-capybara that referenced this pull request Sep 19, 2023
@ydah
Improve for project_spec
56d339d 
Follow up: rubocop/rubocop-rspec#1721
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pirj pirj pirj approved these changes

@bquorning bquorning bquorning approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ydah @pirj @bquorning